Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPP20 warnings except for volatile #4312

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Fix CPP20 warnings except for volatile #4312

merged 1 commit into from
Sep 13, 2021

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Sep 13, 2021

co-authored-by: Nathan Ellingwood ndellin@sandia.gov

@crtrott
Copy link
Member Author

crtrott commented Sep 13, 2021

Tested with:

cmake -DKokkos_ENABLE_OPENMP=ON -DKokkos_ARCH_SKX=ON -DKokkos_ENABLE_COMPILER_WARNINGS=ON -DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-Werror -Wno-deprecated-volatile" -DKokkos_ENABLE_TESTS=ON ~/Kokkos/kokkos

DavidPoliakoff
DavidPoliakoff approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this code, if it passes CI

@crtrott @ndellingwood
Fix CPP20 warnings except for volatile
153022a 
co-authored-by: Nathan Ellingwood <ndellin@sandia.gov>
@crtrott crtrott merged commit 2fc1050 into kokkos:develop Sep 13, 2021
@crtrott crtrott deleted the fix-cpp20-warnings branch September 13, 2021 18:36
@renderdude renderdude mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crtrott @DavidPoliakoff