SYCL: preserve address space by using sycl::global_ptr where sensible #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
sycl_preserve_address_space
branch
from
e6729e6
to
bf053a0
Compare
masterleinad
force-pushed
the
sycl_preserve_address_space
branch
2 times, most recently
from
d321bfb
to
758548c
Compare
masterleinad
changed the title
masterleinad
force-pushed
the
sycl_preserve_address_space
branch
2 times, most recently
from
93f25a5
to
96e00d4
Compare
masterleinad
force-pushed
the
sycl_preserve_address_space
branch
from
96e00d4
to
699b444
Compare
dalg24
reviewed
Feb 25, 2022
| char* const scratch_ptr[2] = {m_scratch_ptr[0], m_scratch_ptr[1]}; | ||
| const auto shmem_begin = m_shmem_begin; | ||
| const int scratch_size[2] = {m_scratch_size[0], m_scratch_size[1]}; | ||
| sycl::global_ptr<char> const global_scratch_ptr = m_global_scratch_ptr; |
There was a problem hiding this comment.
Can you comment about that change? We were not using scratch_ptr[0]?
There was a problem hiding this comment.
No, we are only using scratch_ptr[1] which gets global memory assigned in the constructor. In Cuda and HIP, we set both pointers in the constructor but in SYCL we can only interact with local memory close to kernel execution which is why we always used a different variable for it.
dalg24
approved these changes
Feb 25, 2022
Rombur
approved these changes
Mar 1, 2022
nliber
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to minimize generic space operations