Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate numeric traits on cv-qualified types #4415

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Oct 15, 2021

It occurred to me I had not implemented it today during the LWG review.

@mhoemmen plz review

@dalg24
Copy link
Member Author

dalg24 commented Oct 15, 2021

For reference http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1841r1.pdf
From 17.3.x.1 on page 3

When a numeric trait is instantiated on a cv-qualified type cv T, the trait’s value shall be equal to the value, if any, provided by the specialization on the unqualified type T.

@masterleinad
Copy link
Contributor

Retest this please.

Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! : - D One question (see comment).

core/unit_test/TestNumericTraits.hpp Show resolved Hide resolved
@dalg24 dalg24 force-pushed the numeric_traits_cv_qualified_types branch from 34d69c5 to a6cd71c Compare October 15, 2021 19:30
@crtrott crtrott merged commit ee5906b into kokkos:develop Oct 18, 2021
@dalg24 dalg24 deleted the numeric_traits_cv_qualified_types branch October 18, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants