Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing denorm_min numeric trait #4466

Merged
merged 3 commits into from Oct 27, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Oct 27, 2021

Partial fix for #4442

@dalg24 dalg24 force-pushed the add_missing_numeric_trait_denorm_min branch from d3c41a0 to 3aa4c14 Compare October 27, 2021 13:15
@dalg24
Copy link
Member Author

dalg24 commented Oct 27, 2021

I am puzzled by the CUDA 11.0.211 build issue (error: identifier "FLT_TRUE_MIN" is undefined)
I can't reproduce on the compiler explorer https://godbolt.org/z/MP6h4Y46v. I also pulled the nvidia/cuda:11.0-devel container and it does compile when I pass the -std=c++17 flag

@dalg24
Copy link
Member Author

dalg24 commented Oct 27, 2021

https://godbolt.org/z/qv13E6xKj

Turns out it was a GCC version issue.

I found the *_TRUE_MIN macros are undefined for GCC until 9.2, for Clang until 9 (interestingly for Clang it works when dropping the -std=c++17 flag), for all versions of Intel. Fun stuff...

@crtrott crtrott merged commit 99cded8 into kokkos:develop Oct 27, 2021
@dalg24 dalg24 deleted the add_missing_numeric_trait_denorm_min branch October 27, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants