Add mathematical constants #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
force-pushed
the
math_constants
branch
2 times, most recently
from
46b572e
to
339e91e
Compare
dalg24
force-pushed
the
math_constants
branch
from
339e91e
to
7f88604
Compare
crtrott
approved these changes
Nov 12, 2021
|
Hold on before you merge that one. I probably should have used variable templates. I forgot they were available in C++14 |
|
Except that inline variables only come with C++17... |
fnrizzi
approved these changes
Nov 17, 2021
crtrott
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Discussed this with @dalg24 today there is a slightly different implementation idea in order to avoid introducing traits which are not part of the standard in the public Kokkos namespace (i.e. put the trait into Impl, and only the variable declaration in Kokkos)
nliber
approved these changes
Nov 18, 2021
| #include <Kokkos_Core.hpp> | ||
|
|
||
| template <class T> | ||
| KOKKOS_FUNCTION T *take_address_of(T &arg) { |
There was a problem hiding this comment.
Just curious:: why not use std::addressof?
There was a problem hiding this comment.
__host__ __device__ annotation missing
There was a problem hiding this comment.
dalg24
force-pushed
the
math_constants
branch
from
3f9e920
to
9e03b0c
Compare
crtrott
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4507
Backporting C++20 facility https://eel.is/c++draft/numbers
Individual traits with a
valuemember for each 13 constants defined in the standard.