-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMPTarget team_policy reduce fixes for init/join reductions #4521
OpenMPTarget team_policy reduce fixes for init/join reductions #4521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me but I would clean it up a little.
int max_active_teams = OpenMPTargetExec::MAX_ACTIVE_THREADS / team_size; | ||
const auto nteams = | ||
league_size < max_active_teams ? league_size : max_active_teams; | ||
const auto nteams = league_size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the nteams
should be equal to league_size
. No need to include the max_active_teams
in this case.
The PR fixes the compile time issues arising in kokkos-kernels with OpenMPTarget backend. #4500