Lock constant memory in Cuda/HIP kernel launch with a mutex #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
fix_constant_memory_launch_cuda_hip
branch
from
369193b
to
3d6b036
Compare
crtrott
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant memory used for kernel launches is shared between all
Cuda/HIPexecution space instances. We already guard the access to make sure that the last kernel using the constant memory has finished before copying the next one. This doesn't prevent (different) kernels submitted from independent threads to be copied to the constant memory in a conflict way. Note that we already have a mutex for the case that the same kernel is submitted from different threads.This pull request adds another mutex that guards access to the constant memory globally.