Loosen restriction for using built-in sycl::group_broadcast #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
loosen_sycl_group_broadcast
branch
from
9ae1024
to
9650e0a
Compare
|
Based on top of #4739. |
|
Is this still on your radar? |
masterleinad
force-pushed
the
loosen_sycl_group_broadcast
branch
from
9650e0a
to
b4aa6fb
Compare
Rebased. Thanks for reminding me! |
dalg24
approved these changes
Jun 8, 2022
Rombur
approved these changes
Jun 8, 2022
|
Not waiting for OpenMPTarget build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After intel/llvm#4910 has been merged, we can also use
sycl::group_broadcastforteam_broadcastfor trivially-copyable types.Fixes intel/llvm#4717.