Fix compilation error when using HIP with RDC #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/HIP/Kokkos_HIP_Abort.hpp
Outdated
Comment on lines
57
to
63
| #ifndef KOKKOS_ENABLE_HIP_RELOCATABLE_DEVICE_CODE | ||
| __attribute__((noinline)) | ||
| #else | ||
| inline | ||
| #endif | ||
| void | ||
| hip_abort(char const *msg) { |
There was a problem hiding this comment.
Hmmm... can't you just do
Suggested change
| #ifndef KOKKOS_ENABLE_HIP_RELOCATABLE_DEVICE_CODE | |
| __attribute__((noinline)) | |
| #else | |
| inline | |
| #endif | |
| void | |
| hip_abort(char const *msg) { | |
| [[noreturn]] __device__ __attribute__((noinline)) inline void hip_abort( | |
| char const *msg) { |
Is there a problem declaring the function always inline?
There was a problem hiding this comment.
We decided not to inline because the compiler was generating poor code if you inline the printf. I don't know if the problem has been fixed or not.
There was a problem hiding this comment.
Sure, I didn't argue about __attribute__((noinline)) but was asking about inline.
dalg24
reviewed
Nov 24, 2021
Rombur
force-pushed
the
rdc
branch
2 times, most recently
from
9a854a9
to
f553fb5
Compare
masterleinad
approved these changes
Nov 25, 2021
|
Do you want to add a RDC build on the Jenkins CI? |
|
Retest this please |
Ideally yes but we need ROCm 4.5 and linking with RDC is still very slow :/ |
dalg24
reviewed
Nov 29, 2021
crtrott
requested changes
Nov 30, 2021
dalg24
approved these changes
Nov 30, 2021
crtrott
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR and ROCm 4.5, RDC works.