Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KOKKOS_COMPILER_NVHPC macro, disable quiet_NaN and signaling_NaN #4586

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Add KOKKOS_COMPILER_NVHPC macro, disable quiet_NaN and signaling_NaN #4586

merged 3 commits into from
Dec 3, 2021

Conversation

ndellingwood
Copy link
Contributor

Disable quiet_NaN and signaling_NaN with nvc++ due to compiler issue
during static_assert check "error: expression must have a constant value"
See #4574

@ndellingwood
Add KOKKOS_COMPILER_NVCPP macro, disable quiet_NaN and signaling_NaN
2133aae 
Disable quiet_NaN and signaling_NaN with nvc++ due to compiler issue
during static_assert check "error: expression must have a constant value"
See kokkos#4574
@ndellingwood ndellingwood mentioned this pull request Dec 2, 2021
Closed
@ndellingwood
Copy link
Contributor Author

I confirmed the unit tests successfully compile with nvc++ (21.9) after disabling the tests in this PR

dalg24
dalg24 requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe NV{CPP -> HPC} would be a more standard way to refer to nvc++

core/src/Kokkos_Macros.hpp Outdated Show resolved Hide resolved
core/unit_test/TestNumericTraits.hpp Outdated Show resolved Hide resolved
ndellingwood and others added 2 commits December 2, 2021 23:47
@ndellingwood @dalg24
Update core/src/Kokkos_Macros.hpp
b4c5cbb 
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@ndellingwood @dalg24
Update core/unit_test/TestNumericTraits.hpp
a0315bb 
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
rgayatri23
rgayatri23 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@rgayatri23 rgayatri23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also an issue with the OpenMPTarget backend. The OpenMPTarget backend also has issues with tests involving Kokkos::complex with nvhpc/21.9, but not with earlier compiler versions. Seems like a compiler regression.

@dalg24 dalg24 merged commit 48beb0b into kokkos:develop Dec 3, 2021
@dalg24 dalg24 changed the title Add KOKKOS_COMPILER_NVCPP macro, disable quiet_NaN and signaling_NaN Add KOKKOS_COMPILER_NVHPC macro, disable quiet_NaN and signaling_NaN Dec 3, 2021
@ndellingwood ndellingwood deleted the issue-4574 branch December 3, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@rgayatri23 rgayatri23 rgayatri23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndellingwood @dalg24 @rgayatri23