Deprecate Kokkos::Impl::is_view
#4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
added
the
Refactor
PhilMiller
approved these changes
Dec 6, 2021
crtrott
approved these changes
Dec 6, 2021
|
Add to deprecation list in the wiki! |
I'd argue it is in Also, are you referring to https://github.com/kokkos/kokkos/wiki/DeprecationPage ? It does not really fit with the rest. |
masterleinad
reviewed
Dec 6, 2021
|
Failure on Jenkins (performance) is unrelated. |
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
masterleinad
approved these changes
Dec 7, 2021
|
Yeah ok don't need in the deprecation list .. |
|
SYCL failure is unrelated. (fetnat05 running out of disk space) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational: Seems to only be there for backward compatibility. We don't want users to reach into
Kokkos::Impl::. Let us emit deprecation warnings so we can remove in upcoming releases.