Deprecate Kokkos_ENABLE_PTHREAD in favor of Kokkos_ENABLE_THREADS #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
added
the
Refactor
|
Haven't dealt with Makefiles yet |
|
Please fix the typo in the pr title |
dalg24
changed the title
| IF(Kokkos_ENABLE_THREADS) # for backward compatibility | ||
| SET(Kokkos_ENABLE_PTHREAD ON) | ||
| LIST(APPEND Kokkos_DEVICES PTHREAD) | ||
| ENDIF() | ||
|
|
||
| IF(NOT Kokkos_FIND_QUIETLY) | ||
| MESSAGE(STATUS "Enabled Kokkos devices: ${Kokkos_DEVICES}") |
There was a problem hiding this comment.
So we print Kokkos_THREADS and Kokkos_PTHREAD after this pull request? Is omitting to add PTHREAD to Kokkos_DEVICES feasible?
There was a problem hiding this comment.
I will append after printing. Unfortunately we have to append PTHREAD to Kokkos_DEVICES and set Kokkos_ENABLE_PTHREAD to ON or we may break code downstream.
There was a problem hiding this comment.
Now only appending if Kokkos_ENABLE_DEPRECATED_CODE_3 was ON
nmm0
approved these changes
Dec 15, 2021
Rombur
approved these changes
Dec 16, 2021
masterleinad
approved these changes
Dec 16, 2021
| IF(Kokkos_ENABLE_THREADS) # for backward compatibility | ||
| SET(Kokkos_ENABLE_PTHREAD ON) | ||
| LIST(APPEND Kokkos_DEVICES PTHREAD) | ||
| ENDIF() | ||
|
|
||
| IF(NOT Kokkos_FIND_QUIETLY) | ||
| MESSAGE(STATUS "Enabled Kokkos devices: ${Kokkos_DEVICES}") |
ndellingwood
added a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Dec 17, 2021
Compatibility change in accordance with kokkos/kokkos#4619 Resolves nightly build failures (due to undefined references at link stage) when both Pthreads (not Threads) and Serial backends simultaneously enabled
ndellingwood
added a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Dec 17, 2021
Compatibility change in accordance with kokkos/kokkos#4619 Resolves nightly build failures (due to undefined references at link stage) when both Pthreads (not Threads) and Serial backends simultaneously enabled
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Mar 2, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Mar 14, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 7, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 8, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 18, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 18, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
ndellingwood
added a commit
to trilinos/Trilinos
that referenced
this pull request
Apr 20, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
tcclevenger
pushed a commit
to trilinos/Trilinos
that referenced
this pull request
May 26, 2022
Rename Kokkos_ENABLE_PTHREAD cache variable to Kokkos_ENABLE_THREADS Coincides with kokkos/kokkos#4619 and kokkos/kokkos#4830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4081
It doesn't really make sense to keep enabling with
-DKokkos_ENABLE_PTHREAD=ON.Besides the departure between the exec space name
Kokkos::Threadsand the backend name was a pain.