-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable multiple kernel instantiations when using HIP #4644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider other names for the option?
Should we spell out "kernel instantiation"?
Also please comment why you think the default should be OFF
I couldn't think of a good name. If you have a better one, I am ready to change.
Because that's why @crtrott told me to do. |
OpenMPTarget failure is clearly unrelated
@crtrott @rgayatri23 is that something worth investigating? |
There is no implementation for the instance scope of UniqueToken yet. Only the global scope is implemented. |
@@ -57,6 +57,7 @@ KOKKOS_ENABLE_OPTION(TUNING OFF "Whether to create bindings for tu | |||
KOKKOS_ENABLE_OPTION(AGGRESSIVE_VECTORIZATION OFF "Whether to aggressively vectorize loops") | |||
KOKKOS_ENABLE_OPTION(LAUNCH_COMPILER ON "Whether to potentially use the launch compiler") | |||
KOKKOS_ENABLE_OPTION(COMPILE_AS_CMAKE_LANGUAGE OFF "Whether to use native cmake language support") | |||
KOKKOS_ENABLE_OPTION(HIP_MULTIPLE_KERNEL_INSTANTIATIONS OFF "Whether multiple kernels are instantiated at compile time - improve performance but increase compile time") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KOKKOS_ENABLE_OPTION(HIP_MULTIPLE_KERNEL_INSTANTIATIONS OFF "Whether multiple kernels are instantiated at compile time - improve performance but increase compile time") | |
KOKKOS_ENABLE_OPTION(HIP_MULTIPLE_KERNEL_INSTANTIATIONS OFF "Whether multiple versions for each kernel are instantiated at compile time - improve performance but increase compile time") |
Both HIP builds are passing. Failures are unrelated (issues with one of the testing machine) |
Related to #4546