Store label in SharedAllocationRecord #4647
Conversation
|
Storing the labels in SharedAllocationRecord additionally seems to also fix the broken tests in |
| @@ -149,7 +150,7 @@ class SharedAllocationRecord<void, void> { | |||
| SharedAllocationRecord* arg_root, | |||
| #endif | |||
| SharedAllocationHeader* arg_alloc_ptr, size_t arg_alloc_size, | |||
| function_type arg_dealloc); | |||
| function_type arg_dealloc, const std::string& label); | |||
There was a problem hiding this comment.
Consider taking it by value and moving it.
There was a problem hiding this comment.
In most (all?) cases, we obtain the label as a const std::string& already so I opted for passing by const std::string& here, too. If there are other good reasons to rather pass by value and move, I am happy to adapt, of course.
There was a problem hiding this comment.
As written, there's guaranteed to be a copy into the ultimate m_label member.
In the common case where the label is coming from some temporary object, Damien's suggestion will allow the compiler to do elision, and construct the temporary directly into the function argument, which will then get inexpensively moved from.
There was a problem hiding this comment.
I agree with that but we never pass a temporary object here.
Anyway, if anyone requests changes, I will change.
|
This implements #2029 (comment), i.e we are storing the label additionally/redundantly in |
Fixes #2029. Supersedes #4615.