Kokkos::resize always error out for mismatch in runtime rank #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
Jan 17, 2022
dalg24
approved these changes
Jan 17, 2022
ajpowelsnl
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be close enough to fix #1714. The constructor of View errors out anyway and the error message shouldn't be too far off to deduce that the problem might come from another function calling the constructor (which is
resizein the issue).The changes here specifically make sure that we still error out if the dimensions given to
resizematch up to the run-time rank but are different after that. Previously, we were just ignoring the extra arguments.