Desul: Add ScopeCaller

[crtrott]

In Serial only builds Kokkos::atomics will use ScopeCaller

[crtrott]

Corresponding PR in Desul: desul/desul#50

Note I applied desul clang-format too

[dalg24]

Would you do the formatting part in a separate PR?

[dalg24]

Suggested change

	// error: large atomic operation may incur significant performance penalty
	// [-Werror,-Watomic-alignment] https://godbolt.org/z/G7YhqhbG6
	// clang-format off
	// error: large atomic operation may incur significant performance penalty [-Werror,-Watomic-alignment]
	// clang-format on
	// https://godbolt.org/z/G7YhqhbG6

Uggg. Did we merge that into Desul?

[crtrott]

yeah

[dalg24]

I'd prefer if you submitted the changes to <desul/atomics/Generic.hpp> in another PR

[masterleinad]

Looks OK to me (despite that the name feels unintuitive at least for the current use case to me). We at least have the Windows build and the OSX builds to test this.

[dalg24]

I'll cut you a deal. I close my eyes and merge this PR as is and you agree to split up your PR on the Desul side.
What do you say?

[crtrott]

Sure Damien :-)

[ajpowelsnl]

Morning @dalg24 and @crtrott -- is this issue still a blocker (given that it's been merged)?

[ajpowelsnl]

Good morning @dalg24 and @crtrott -- Can we close this issue?

[dalg24]

This is a pull request not an issue and it has been merged.