Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kokkos_launch_compiler: escape $ character #4703

Merged
merged 2 commits into from
Jan 27, 2022
Merged

kokkos_launch_compiler: escape $ character #4703

merged 2 commits into from
Jan 27, 2022

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Jan 20, 2022

fixes #4687

@cz4rs cz4rs linked an issue Jan 20, 2022 that may be closed by this pull request
kokkos_launch_compiler removes escaped characters #4687
Closed
@cz4rs cz4rs changed the title [WIP] kokkos_launch_compiler fixes [WIP] fix kokkos_launch_compiler removes escaped characters Jan 24, 2022
@crtrott
Copy link
Member

crtrott commented Jan 25, 2022

lol seems to be complicated to get this to work ...

@cz4rs cz4rs mentioned this pull request Jan 26, 2022
Closed
@cz4rs
Copy link
Contributor Author

cz4rs commented Jan 26, 2022

lol seems to be complicated to get this to work ...

After bashing my head against my desk a couple of times I think I finally got it right 🤦‍♂️

Btw Shellcheck shows multiple warnings for kokkos_launch_compiler, but fixing them actually breaks the script. Considering that it's just before the release, I have reduced the changes to minimum.

@cz4rs cz4rs added this to In progress in Developer: Cezary Skrzyński via automation Jan 26, 2022
@cz4rs cz4rs marked this pull request as ready for review January 26, 2022 11:03
@cz4rs cz4rs changed the title [WIP] fix kokkos_launch_compiler removes escaped characters kokkos_launch_compiler: escape $ character Jan 26, 2022
dalg24
dalg24 reviewed Jan 26, 2022
View reviewed changes
bin/kokkos_launch_compiler Outdated Show resolved Hide resolved
@cz4rs cz4rs added this to In progress in Kokkos Release 3.6 via automation Jan 26, 2022
@cz4rs cz4rs moved this from In progress to Awaiting Feedback in Kokkos Release 3.6 Jan 26, 2022
@cz4rs cz4rs added the Blocks Promotion Overview issue for release-blocking bugs label Jan 26, 2022
@cz4rs
Copy link
Contributor Author

cz4rs commented Jan 27, 2022

Confirmed to work by the original poster (#4687 (comment)).

@crtrott crtrott merged commit dc4073a into kokkos:develop Jan 27, 2022
Kokkos Release 3.6 automation moved this from Awaiting Feedback to Done Jan 27, 2022
Developer: Cezary Skrzyński automation moved this from In progress to Done Jan 27, 2022
@dalg24 dalg24 mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
Blocks Promotion Overview issue for release-blocking bugs
Projects
Developer: Cezary Skrzyński
Done
Kokkos Release 3.6
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kokkos_launch_compiler removes escaped characters
3 participants
@cz4rs @crtrott @dalg24