Specify device type everywhere in Kokkos_Random.hpp #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Jan 27, 2022
masterleinad
force-pushed
the
device_type_random
branch
from
8e7f385
to
957814b
Compare
|
@masterleinad this resolved the Intrepid2 compilation issue |
dalg24
requested changes
Jan 27, 2022
dalg24
previously requested changes
Jan 27, 2022
crtrott
approved these changes
Jan 27, 2022
dalg24
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4723 by using the device type everywhere (and making sure that we really use a device type even if
DeviceTypeis not).