Deprecate partition_master, validate_partition
#4737
Conversation
|
Don't we need to protect the test or is that not getting compiled anymore? |
| #ifdef KOKKOS_ENABLE_DEPRECATED_CODE_3 | ||
| template <typename F> | ||
| static void partition_master(F const &, int requested_num_partitions = 0, | ||
| int = 0) { | ||
| KOKKOS_DEPRECATED static void partition_master( | ||
| F const &, int requested_num_partitions = 0, int = 0) { | ||
| if (requested_num_partitions > 1) { | ||
| Kokkos::abort( | ||
| "Kokkos::Experimental::HPX::partition_master: can't partition an " | ||
| "HPX instance\n"); | ||
| } | ||
| } | ||
| #endif |
There was a problem hiding this comment.
@msimberg making sure you see this
| Impl::OpenMPExec::verify_is_master("OpenMP::print_configuration"); | ||
| #endif |
There was a problem hiding this comment.
I think this needs to stay. Essentially the verify_is_master is there to prevent you from doing this:
#pragma omp parallel
{
Kokkos;:parallel_for(N, functor);
}Or do I misread that?
There was a problem hiding this comment.
I think you are right, I have been overzealous with this one. This should probably become deprecated after other changes from #4119 land.
cz4rs
changed the title
partition_master, validate_partition, verify_is_masterpartition_master, validate_partition
|
Why did you decide to leave |
|
Morning @cz4rs -- Is this still a blocker for 3.6? I see something was merged a couple of weeks ago, but I'm not sure of its status now. |
Hi Amy, I believe this is fine as is - the functions were marked deprecated as requested, other work (removal / refactoring) will be carried out in the next release. |
Thanks, Cezary! If this issue has been completed, then can we close it, with a view to opening new, related issue(s) for the next release? |
ajpowelsnl
added
Blocks Promotion
Deprecate mentioned functions in preparation for their removal (see #4119).
This was briefly discussed at Kokkos Developer Meeting - please complain if you feel like voting is required.