Implement fill_random for DynRankView #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Feb 8, 2022
PhilMiller
approved these changes
Feb 8, 2022
PhilMiller
reviewed
Feb 8, 2022
| std::to_string(rank(a))); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If I could make this variadic in the Viewish arguments, then it could be used for the non-scalar deep_copy implementations, too. It would then have to handle mixes of View and DynRankView. With C++17, that could just be a folded logical-or over the condition in the enable_if.
|
The putative use case for the |
|
I was wondering about perf impact, but the original implementation is SOOO shitty perf wise that it doesn't matter I guess .... |
crtrott
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3437.