-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More math functions #4768
More math functions #4768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I checked that the respective SYCL
functions are indeed not implemented.
We should add unit tests, though.
Withdrawing the functions that are prefix with |
|
Failure with Clang+CUDA
|
On 2nd thought withdrawing |
Retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me,
Failure is clearly unrelated (clang crashing when compiling |
Fix #4765
Partially resolving #4767
Adding
round
,rint
,logb
,nextafter
,copysign
, andsignbit
Addinground
,lround
*,llround
**,rint
,lrint
*,llrint
**,logb
,nextafter
,copysign
, andsignbit
Naming functions that are missing in comments
** are missing with the SYCL backend