do not call eval, because arguments should not be interpreted and only forwarded #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
OK to test |
PhilMiller
approved these changes
Feb 8, 2022
|
@Azrael3000 @cz4rs please review |
Azrael3000
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4766
I also add a small cmake project which uses fancy names. Filenames which contain a $ fail with nvcc, that cannot be fixed without a fix in nvcc.
Filenames that contain a whitespace need further fixes in nvcc_wrapper, which I added to the zip archive, but it is not part of this PR, because my usecase is fixed with the changes and the changes in nvcc_wrapper are quite invasive.
kokkos_launch_compiler.zip