Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMPTarget: Update the size_type #4779

Merged
merged 1 commit into from
Feb 15, 2022
Merged

OpenMPTarget: Update the size_type #4779

merged 1 commit into from
Feb 15, 2022

Conversation

rgayatri23
Copy link
Contributor

The PR updates the size_type used as the index from size_t to unsigned. This improves the performance with the llvm compiler.

@rgayatri23
Copy link
Contributor Author

Retest this please.

@dalg24
Copy link
Member

dalg24 commented Feb 15, 2022

Out of curiosity did you try signed integers?

@rgayatri23
Copy link
Contributor Author

Out of curiosity did you try signed integers?

Yes, I observed a slight performance regression when using signed integers.

@crtrott crtrott merged commit a5967dc into kokkos:develop Feb 15, 2022
@rgayatri23 rgayatri23 deleted the OpenMPTarget_update_size_type branch March 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@crtrott crtrott crtrott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgayatri23 @dalg24 @crtrott