Promote mathematical functions to Kokkos namespace
#4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
force-pushed
the
promote_math_functions
branch
from
28df30b
to
44ccd4f
Compare
dalg24
commented
Feb 16, 2022
Comment on lines
-156
to
-162
| #ifdef KOKKOS_ENABLE_DEPRECATED_CODE_3 | ||
|
|
||
| KOKKOS_DEPRECATED KOKKOS_INLINE_FUNCTION int log2(unsigned i) { | ||
| return Impl::int_log2(i); | ||
| } | ||
|
|
||
| #endif |
There was a problem hiding this comment.
We can't keep it if we proceed and promote the math functions.
dalg24
force-pushed
the
promote_math_functions
branch
3 times, most recently
from
ba20362
to
7810dee
Compare
dalg24
force-pushed
the
promote_math_functions
branch
from
7810dee
to
4525310
Compare
dalg24
added this to In progress
in Kokkos Release 3.7 -- 2022 Target Date
via automation
masterleinad
approved these changes
Feb 17, 2022
Rombur
approved these changes
Feb 18, 2022
| @@ -47,6 +47,7 @@ | |||
|
|
|||
| #include <Kokkos_Macros.hpp> | |||
| #include <cmath> | |||
| #include <cstdlib> | |||
There was a problem hiding this comment.
abs overloads that takes integral types. Amy had this issue on OS X earlier this week and Christian and I had to add it when trying to resolve issues with the Fujitsu compiler. Also #4727 (comment).
Required to avoid ambiguities later with Kokkos::complex
…hen deprecated code is enabled
dalg24
force-pushed
the
promote_math_functions
branch
from
6ac05e1
to
d779ae9
Compare
crtrott
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all math functions from
Kokkos::Experimental::toKokkos::namespace.Provide using-declaration in the
Kokkos::Experimental::namespace when deprecated code is enabled to ease the transition.Deprecated function
log2(unsigned) -> intis being removed.