Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CMake version check up #4797

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Move CMake version check up #4797

merged 2 commits into from
Feb 18, 2022

Conversation

masterleinad
Copy link
Contributor

Supersedes #4796 following #4789 (comment). Also avoid redundantly setting CMP0054 and CMP0057 (except for KokkosConfig.cmake.in).

dalg24
dalg24 reviewed Feb 17, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@masterleinad masterleinad mentioned this pull request Feb 17, 2022
Merged
@masterleinad
Copy link
Contributor Author

I verified that cmake_minimum_required only has local effects with respect to add_subdirectory and that's also the mechanism Trilinos/TrBITS is using to build Kokkos.

dalg24
dalg24 reviewed Feb 17, 2022
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@masterleinad
Copy link
Contributor Author

Cuda-9.2 failing with

[  FAILED  ] default_exec.overlap_mdrange_policy

appears to be unrelated/spurious.

@crtrott crtrott merged commit dad9d3b into kokkos:develop Feb 18, 2022
@PhilMiller
Copy link
Contributor

Did this potentially also address #2503?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii left review comments

@dalg24 dalg24 dalg24 approved these changes

@cz4rs cz4rs cz4rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@masterleinad @PhilMiller @dalg24 @henryiii @cz4rs @crtrott