Add Kokkos::create_mirror[_view] WithoutInitializing for Container types #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @masterleinad! |
PhilMiller
reviewed
Feb 18, 2022
PhilMiller
reviewed
Feb 18, 2022
masterleinad
force-pushed
the
more_create_mirror
branch
from
064267e
to
96bffd4
Compare
PhilMiller
approved these changes
Mar 2, 2022
crtrott
approved these changes
Mar 23, 2022
| typename Impl::MirrorDRVType<Space, T, P...>::view_type create_mirror( | ||
| const Space&, const Kokkos::DynRankView<T, P...>& src) { | ||
| return typename Impl::MirrorDRVType<Space, T, P...>::view_type( | ||
| src.label(), Impl::reconstructLayout(src.layout(), src.rank())); |
There was a problem hiding this comment.
Should this pass the space argument to the view construction? I guess it would be a behavior change with regards to syncing or?
There was a problem hiding this comment.
Space is (allowed to be) a memory space. We can discuss if we want to specialize for the case that an execution space is provided but I would prefer to do that uniformly with the other create_mirror overloads in a separate pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4794, in continuation of #4486.
StaticCrsGraphalso providescreate_mirror[_view]but with somewhat different semantics so I decided to omit it here.