Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Kokkos::abort() causes abnormal program termination when called on the host-side #4808

Merged
merged 13 commits into from
Feb 23, 2022
Merged

Make sure Kokkos::abort() causes abnormal program termination when called on the host-side #4808

merged 13 commits into from
Feb 23, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Feb 21, 2022 •
edited

"Regularize" behavior of Kokkos::abort as much as currently possible:

  • always causing abnormal program termination when called from the host-side (was previously ignored when OPENMPTARGET backend was enabled)
  • call abort on the host-side at the next synchronization point with CUDA instead of throwing a runtime error

@dalg24 dalg24 marked this pull request as ready for review February 22, 2022 18:58
masterleinad
masterleinad reviewed Feb 22, 2022
View reviewed changes
core/src/Cuda/Kokkos_Cuda_Error.hpp Outdated Show resolved Hide resolved
core/src/Cuda/Kokkos_Cuda_Error.hpp Outdated Show resolved Hide resolved
core/src/impl/Kokkos_Error.hpp Outdated Show resolved Hide resolved
rgayatri23
rgayatri23 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@rgayatri23 rgayatri23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dalg24
dalg24 commented Feb 22, 2022
View reviewed changes
core/unit_test/TestAbort.hpp Outdated Show resolved Hide resolved
@dalg24 @masterleinad
Add [[noreturn]] attribute to abort on the host-side with SYCL
a6d5c5c 
Co-Authored-By: Daniel Arndt <arndtd@ornl.gov>
masterleinad
masterleinad approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through my comments!

@dalg24 dalg24 merged commit 57b622e into kokkos:develop Feb 23, 2022
@dalg24 dalg24 deleted the abort branch February 23, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@masterleinad masterleinad masterleinad approved these changes

@crtrott crtrott crtrott approved these changes

@rgayatri23 rgayatri23 rgayatri23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dalg24 @Rombur @masterleinad @crtrott @rgayatri23