Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HIP version when printing the configuration #4872

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix HIP version when printing the configuration #4872

merged 1 commit into from
Mar 14, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 14, 2022 •
edited

https://rocmdocs.amd.com/en/latest/Programming_Guides/HIP-FAQ.html#how-is-the-hip-version-defined

HIP_VERSION=HIP_VERSION_MAJOR * 10000000 + HIP_VERSION_MINOR * 100000 + HIP_VERSION_PATCH)

I propose to use the macros directly rather than deducing the major/minor/patch versions ourselves.

@dalg24 dalg24 added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 14, 2022
@dalg24 dalg24 requested a review from Rombur March 14, 2022 18:36
@dalg24 dalg24 changed the title Fixup HIP_VERSION in print_configuration(std::ostream&) Fix HIP version when printing the configuration Mar 14, 2022
@crtrott crtrott merged commit 76930ac into kokkos:develop Mar 14, 2022
@masterleinad masterleinad mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Patch Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dalg24 @Rombur @masterleinad @PhilMiller @crtrott