Fixup View::access()
truncate parameter pack
#4876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4862
In #4800, I elected to forward all arguments from the parameter pack in
View::access
to the underlyingViewMapping
implementation and relied on it being able to handle extra arguments. Sacado's specialization ofViewMapping
(which only allow up to rank-7) did not implement anaccess
template function that takes 8 arguments.Here, I propose, in some sense, to rollback part of the changes from #4800, by truncating the extra arguments before accessing elements using
ViewMapping
.Note that I considered a more generic approach but gave up mainly because it clashes with our current implementation that does not trust the compiler to properly inline.