Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup View::access() truncate parameter pack #4876

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 15, 2022

Fix #4862

In #4800, I elected to forward all arguments from the parameter pack in View::access to the underlying ViewMapping implementation and relied on it being able to handle extra arguments. Sacado's specialization of ViewMapping (which only allow up to rank-7) did not implement an access template function that takes 8 arguments.
Here, I propose, in some sense, to rollback part of the changes from #4800, by truncating the extra arguments before accessing elements using ViewMapping.
Note that I considered a more generic approach but gave up mainly because it clashes with our current implementation that does not trust the compiler to properly inline.

@dalg24 dalg24 added the Refactor Tidying up: make code code, cleaner, simpler, understandable and robust label Mar 15, 2022
@dalg24 dalg24 marked this pull request as ready for review March 15, 2022 16:26
@dalg24 dalg24 merged commit 6ab5644 into kokkos:develop Mar 18, 2022
@dalg24 dalg24 deleted the truncate_parameter_pack_forwarded_to_view_mapping branch March 21, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Tidying up: make code code, cleaner, simpler, understandable and robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants