Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose Kokkos_ARCH_INTEL_GEN for SYCL to mean JIT to be conforming with OMPT #4894

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

masterleinad
Copy link
Contributor

Currently, Kokkos_ARCH_INTEL_GEN is used for SYCL to compile AOT for all architectures from Gen9 on which is pretty useless and will not even succeed since not all features used are supported for all architectures. For OpenMPTarget, we don't have AOT flags (but we should likely just use the ones we have for SYCL already) but I was told that Kokkos_ARCH_INTEL_GEN means JIT compilation.
This pull request repurposes Kokkos_ARCH_INTEL_GEN for SYCL to also mean JIT compilation to facilitate switching between SYCL and OMPT in a consistent way with respect to architecture flags.

Documentation:

@zippylab
Copy link

This would be helpful for Aurora apps development using Kokkos. The logic for OMPT to specify various AoT targets could then be just the same (as it has almost been in locally-modified kokkos_arch.cmake files for OMPT. Explicitly putting in the -fsycl-targets=spir64 (and -fopenmp-targets=spir64 as has been done locally for OMPT) would help make it transparent that JIT is to be used.

@crtrott crtrott merged commit 51dd896 into kokkos:develop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants