Enable accessing Kokkos::Array elements in constant expressions #4916

dalg24 · 2022-03-30T14:32:44Z

Fix #4905
The tricky part was the custom error messages for out of bounds accesses.
The string manipulation facility is a bit heavy handed but we will need something like that anyway to produce better error messages with memory access violations in Kokkos::View.
I decided to call abort from the host-side as well instead of throwing a runtime error.

core/src/impl/Kokkos_StringManipulation.hpp

core/unit_test/TestStringManipulation.cpp

…ument is null

dalg24 · 2022-03-31T13:41:30Z

Retest this please

masterleinad · 2022-03-31T15:38:00Z

Retest this please.

PhilMiller · 2022-03-31T22:32:34Z

Looks like this makes lots of files warn under NVCC 11.6:
https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56

[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1092)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1093)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1094)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1095)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1096)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1097)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1098)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1099)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1100)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1101)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1102)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1103)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1104)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1105)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1106)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1107)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1108)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1109)[](https://cloud.cees.ornl.gov/jenkins-ci/blue/organizations/jenkins/Kokkos/detail/Kokkos/8532/pipeline/56#step-359-log-1110)/var/jenkins/workspace/Kokkos/core/src/impl/Kokkos_StringManipulation.hpp(203): warning #186-D: pointless comparison of unsigned integer with zero

          detected during:

            instantiation of "Kokkos::Impl::to_chars_result Kokkos::Impl::to_chars_i(char *, char *, Integral) [with Integral=size_t]" 

/var/jenkins/workspace/Kokkos/core/src/Kokkos_Array.hpp(86): here

            instantiation of "Kokkos::Impl::ArrayBoundsCheck<Integral, false>::ArrayBoundsCheck(Integral, size_t) [with Integral=const int &]" 

/var/jenkins/workspace/Kokkos/core/src/Kokkos_Array.hpp(134): here

            instantiation of "Kokkos::Array<T, N, Proxy>::reference Kokkos::Array<T, N, Proxy>::operator[](const iType &) [with T=int64_t, N=2UL, Proxy=void, iType=int]" 

/var/jenkins/workspace/Kokkos/core/src/KokkosExp_MDRangePolicy.hpp(351): here

            instantiation of "void Kokkos::MDRangePolicy<Properties...>::init_helper(Kokkos::Impl::TileSizeProperties) [with Properties=<Kokkos::DefaultHostExecutionSpace, Kokkos::Rank<2U, Kokkos::Iterate::Right, Kokkos::Iterate::Right>, Kokkos::IndexType<int64_t>>]" 

/var/jenkins/workspace/Kokkos/core/src/KokkosExp_MDRangePolicy.hpp(296): here

            instantiation of "Kokkos::MDRangePolicy<Properties...>::MDRangePolicy(const Kokkos::Impl::PolicyTraits<Properties...>::execution_space &, const Kokkos::MDRangePolicy<Properties...>::point_type &, const Kokkos::MDRangePolicy<Properties...>::point_type &, const Kokkos::MDRangePolicy<Properties...>::tile_type &) [with Properties=<Kokkos::DefaultHostExecutionSpace, Kokkos::Rank<2U, Kokkos::Iterate::Right, Kokkos::Iterate::Right>, Kokkos::IndexType<int64_t>>]" 

/var/jenkins/workspace/Kokkos/core/src/KokkosExp_MDRangePolicy.hpp(279): here

            instantiation of "Kokkos::MDRangePolicy<Properties...>::MDRangePolicy(const Kokkos::Impl::PolicyTraits<Properties...>::execution_space &, const LT (&)[LN], const UT (&)[UN], const TT (&)[TN]) [with Properties=<Kokkos::DefaultHostExecutionSpace, Kokkos::Rank<2U, Kokkos::Iterate::Right, Kokkos::Iterate::Right>, Kokkos::IndexType<int64_t>>, LT=int, LN=2UL, UT=unsigned long, UN=2UL, TT=int64_t, TN=2UL, <unnamed>=void]" 

/var/jenkins/workspace/Kokkos/core/src/Kokkos_CopyViews.hpp(118): here

            instantiation of "Kokkos::Impl::ViewFill<ViewType, Layout, ExecSpace, 2, iType>::ViewFill(const ViewType &, ViewType::const_value_type &, const ExecSpace &) [with ViewType=Kokkos::View<double **, Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::AnonymousSpace>, Kokkos::MemoryTraits<0U>>, Layout=Kokkos::LayoutRight, ExecSpace=Kokkos::DefaultHostExecutionSpace, iType=int64_t]" 

/var/jenkins/workspace/Kokkos/core/src/Kokkos_CopyViews.hpp(1434): here

            instantiation of "void Kokkos::deep_copy(const Kokkos::View<DT, DP...> &, Kokkos::ViewTraits<DT, DP...>::const_value_type &, std::enable_if<std::is_same<Kokkos::ViewTraits<DT, DP...>::specialize, void>::value, void>::type *) [with DT=double **, DP=<Kokkos::LayoutStride, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::HostSpace::memory_space>, Kokkos::MemoryManaged>]" 

/var/jenkins/workspace/Kokkos/core/unit_test/TestLocalDeepCopy.hpp(68): here

            instantiation of "void Test::impl_test_local_deepcopy_teampolicy_rank_1<ExecSpace,ViewType>(int) [with ExecSpace=Kokkos::Serial, ViewType=Kokkos::View<double ********, Kokkos::LayoutLeft, Kokkos::Serial>]" 

/var/jenkins/workspace/Kokkos/core/unit_test/TestLocalDeepCopy.hpp(941): here

dalg24 · 2022-03-31T22:55:51Z

core/src/impl/Kokkos_StringManipulation.hpp(203): warning #186-D: pointless comparison of unsigned integer with zero

dalg24 · 2022-03-31T22:58:04Z

There are also a lot of core/src/impl/Kokkos_Error.hpp(117): warning #1305-D: function declared with "noreturn" does return

PhilMiller · 2022-03-31T23:06:20Z

There are also a lot of core/src/impl/Kokkos_Error.hpp(117): warning #1305-D: function declared with "noreturn" does return

I looked into that a little bit, and I think nvcc is being screwy. The preprocessed source doesn't declare device_abort as noreturn

dalg24 · 2022-03-31T23:14:35Z

core/src/impl/Kokkos_StringManipulation.hpp

+
+//<editor-fold desc="String examination">
+// returns the length of a given string
+KOKKOS_FUNCTION constexpr std::size_t strlen(const char *str) {


These need to be declared inline. Will fix.

dalg24 added 5 commits March 30, 2022 10:24

Constexpr array, disable custom error msg temporarily

936237f

Add string manipulation facility

29eeffe

Re-enable error message in out-of-bounds accesses

4c8f3d9

Always call abort for out-of-bounds accesses

880903b

Remove duplicated functionality

88acc1e

dalg24 requested a review from nliber March 30, 2022 16:39

nliber requested changes Mar 30, 2022

View reviewed changes

Workaround GCC bug in strncmp

e7b58e9

dalg24 force-pushed the array_constexpr_element_access branch from 9b9cac6 to e7b58e9 Compare March 30, 2022 19:39

dalg24 added 4 commits March 30, 2022 18:24

Per review do not define behavior when either of the char pointer arg…

7977260

…ument is null

Add tests with count zero

b295df1

Workaround NVCC version less than 11.3

43677a0

Remove now unused <string> header include

9b893d9

nliber approved these changes Mar 31, 2022

View reviewed changes

crtrott approved these changes Mar 31, 2022

View reviewed changes

crtrott merged commit 34aab59 into kokkos:develop Mar 31, 2022

dalg24 deleted the array_constexpr_element_access branch March 31, 2022 17:58

dalg24 commented Mar 31, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable accessing Kokkos::Array elements in constant expressions #4916

Enable accessing Kokkos::Array elements in constant expressions #4916

dalg24 commented Mar 30, 2022

dalg24 commented Mar 31, 2022

masterleinad commented Mar 31, 2022

PhilMiller commented Mar 31, 2022

dalg24 commented Mar 31, 2022 •

edited

dalg24 commented Mar 31, 2022 •

edited by PhilMiller

PhilMiller commented Mar 31, 2022

dalg24 Mar 31, 2022

Enable accessing Kokkos::Array elements in constant expressions #4916

Enable accessing Kokkos::Array elements in constant expressions #4916

Conversation

dalg24 commented Mar 30, 2022

dalg24 commented Mar 31, 2022

masterleinad commented Mar 31, 2022

PhilMiller commented Mar 31, 2022

dalg24 commented Mar 31, 2022 • edited

dalg24 commented Mar 31, 2022 • edited by PhilMiller

PhilMiller commented Mar 31, 2022

dalg24 Mar 31, 2022

Choose a reason for hiding this comment

dalg24 commented Mar 31, 2022 •

edited

dalg24 commented Mar 31, 2022 •

edited by PhilMiller