Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup let RangePolicy::set_chunk_size return a reference to self #4918

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Fixup let RangePolicy::set_chunk_size return a reference to self #4918

merged 2 commits into from
Mar 31, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 30, 2022

Per our discussion, to be consistent with TeamPolicy::set_chunk_size and because that is how this pattern should be implemented

@dalg24
Copy link
Member Author

dalg24 commented Mar 31, 2022

Failure (building one of the Docker image) is clearly unrelated.

@dalg24 dalg24 merged commit b9c247e into kokkos:develop Mar 31, 2022
@dalg24 dalg24 deleted the range_policy_set_chunk_size branch March 31, 2022 18:15
@dalg24 dalg24 mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtrott crtrott crtrott approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dalg24 @crtrott @fnrizzi