Avoid forcing matching execution spaces in BinSort constructor and sort() #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janciesko
approved these changes
Mar 30, 2022
crtrott
requested changes
Mar 31, 2022
| template <class ExecutionSpace = execution_space> | ||
| void create_permute_vector(const ExecutionSpace& exec = execution_space{}) { | ||
| template <class ExecutionSpace = exec_space> | ||
| void create_permute_vector(const ExecutionSpace& exec = exec_space{}) { | ||
| const size_t len = range_end - range_begin; |
There was a problem hiding this comment.
can we make a check here that (i.e. static_assert) that ExecutionSpace can access the memory space of the view?
There was a problem hiding this comment.
dalg24
requested changes
Mar 31, 2022
dalg24
approved these changes
Mar 31, 2022
crtrott
approved these changes
Mar 31, 2022
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4891. Having an
execution_spacealias forces that to be considered when executing functors. This is not what we want.This pull requests just renames
execution_spacetoexec_space.