Add option to optimize for CPU architecture of local machine #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we make a list of pros/cons for this? And what the implications are? I don't see why this can cause weird problems. |
cz4rs
approved these changes
Apr 4, 2022
mzuzek
approved these changes
Apr 4, 2022
|
Retest this please. |
masterleinad
added
the
Question
masterleinad
changed the title
nliber
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO there are a lot of cases where the targeted machine is the same as the one compiled on and adding a
nativeoption simplifies the choice in these cases and also allows optimizing for architectures that we don't already have a separate configuration option for.