Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make View::shmem_size() device-callable #4936

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Make View::shmem_size() device-callable #4936

merged 6 commits into from
Apr 29, 2022

Conversation

ldh4
Copy link
Contributor

@ldh4 ldh4 commented Apr 4, 2022

To resolve #4925

@ldh4 ldh4 marked this pull request as ready for review April 11, 2022 22:21
@ldh4
Copy link
Contributor Author

ldh4 commented Apr 11, 2022

Please retest this.
Changes made in this commit to add KOKKOS_INLINE_FUNCTION are only relevant to Cuda and HIP backends.
I am not sure why a performance test on SYCL backend is affected by this.

@ajpowelsnl
Copy link
Contributor

Check for spurious failures.

cz4rs
cz4rs approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

dalg24
dalg24 approved these changes Apr 28, 2022
View reviewed changes
core/unit_test/TestViewAPI_e.hpp Outdated Show resolved Hide resolved
@dalg24 dalg24 merged commit d641789 into kokkos:develop Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@cz4rs cz4rs cz4rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ldh4 @ajpowelsnl @dalg24 @cz4rs