Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Kokkos::is_reducer_type #4957

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Apr 12, 2022

Rational: obscure duplicate functionality

Haven't found any usage in Trilinos. I suggest we deprecate/remove.

@dalg24
Copy link
Member Author

dalg24 commented Apr 12, 2022

For reference is_reducer is defined here

KOKKOS_IMPL_IS_CONCEPT(reducer)
which is expanded using
#define KOKKOS_IMPL_IS_CONCEPT(CONCEPT) \
template <typename T> \
struct is_##CONCEPT { \
private: \
template <typename U> \
using have_t = typename U::CONCEPT; \
template <typename U> \
using have_type_t = typename U::CONCEPT##_type; \
\
public: \
static constexpr bool value = \
std::is_base_of<detected_t<have_t, T>, T>::value || \
std::is_base_of<detected_t<have_type_t, T>, T>::value; \
constexpr operator bool() const noexcept { return value; } \
};

@dalg24 dalg24 added Refactor Tidying up: make code code, cleaner, simpler, understandable and robust Deprecate Items to be deprecated labels Apr 12, 2022
@crtrott crtrott merged commit 7093fcf into kokkos:develop Apr 13, 2022
@dalg24 dalg24 deleted the deprecate_is_reducer_type branch April 13, 2022 02:25
@ajpowelsnl ajpowelsnl mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Items to be deprecated Refactor Tidying up: make code code, cleaner, simpler, understandable and robust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants