Fix bounds errors with Kokkos::sort #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
We have noticed that `Kokkos::sort` sometimes fails in HIP. This adds a test that demonstrates this bug. When I compile Kokkos on the crusher platform at OLCF using the ROCm 5.1.0 module, this test fails. This can be used to determine what is going wrong with sort and provide a regression test for it.
|
OK to test |
|
I casted everything to |
kmorel
changed the title
|
There is a |
|
Failure (issue with NVIDIA GPG repo key on the Clang+CUDA build) is unrelated. This is ready. |
nliber
approved these changes
Apr 29, 2022
crtrott
approved these changes
May 3, 2022
Rombur
approved these changes
May 3, 2022
| // For integral types the number of bins may be larger than the range | ||
| // in which case we can exactly have one unique value per bin | ||
| // and then don't need to sort bins. | ||
| if (std::is_integral<typename KeyViewType::const_value_type>::value && | ||
| static_cast<uint64_t>(range_) <= static_cast<uint64_t>(max_bins__)) { | ||
| (static_cast<double>(max) - static_cast<double>(min)) <= |
There was a problem hiding this comment.
Suggested change
| (static_cast<double>(max) - static_cast<double>(min)) <= | |
| (static_cast<double>(max) - min_) <= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that
Kokkos::sortsometimes fails in HIP. Thisadds a test that demonstrates this bug. When I compile Kokkos
on the crusher platform at OLCF using the ROCm 5.1.0 module, this
test fails. This can be used to determine what is going wrong
with sort and provide a regression test for it.
Note that this PR does not fix anything. Rather, this just
demonstrates the problem reported in #4978. I provide this to
the Kokkos developers so they have a simple way to replicate the
problem in #4978.