Drop Instruction Set Architecture (ISA) macros #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
Apr 27, 2022
|
(Applied clang-format) |
Macros KOKKOS_{USE -> ENABLE}_ISA_{X86_64,KNC,POWERPCLE,POWERPCBE} definitions (KOKKOS_USE_ISA_*) did not match guarding in code (KOKKOS_ENABLE_ISA_*)
Proposing to remove altogether rather than trying to "fix". Pre-desul atomics source files were intentionally left out.
|
Failure (fetnat03 out of space) is clearly unrelated |
nmm0
approved these changes
Apr 27, 2022
|
Because I expect we will remove these files in the near future. Desul atomics are used unless the user explicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing an alternate resolution to #4947
Macros
KOKKOS_{USE -> ENABLE}_ISA_{X86_64,KNC,POWERPCLE,POWERPCBE}definitions (#define KOKKOS_USE_ISA_*) do not match guarding in code (#ifdef KOKKOS_ENABLE_ISA_*)It appears to have been broken for (ever?) a long time.
#4947 proposes to define
KOKKOS_ENABLE_ISA_*next to the existingKOKKOS_USE_ISA_*macros. (PR was only dealing with theX86_64macro which being actually used in our codebase.This PR suggests to remove these macros altogether rather than trying to "fix" the situation. Pre-desul atomics source files were intentionally left out.