Fix for Kokkos::vector::insert into empty vector with begin and end iterators #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the out of range check on it to use std::less, as one cannot portably perform ordered pointer comparisons on pointers that aren't pointing inside the same array (to a first approximation). Removed the special case when inserting into an empty vector, as it was incorrect (see issue kokkos#4975) and has no real performance gain (unlike this special case in insert(it, count, val)). Removed the special case when inserting zero elements, as there is no need to hand optimize for this rare case, as it falls out of the general algorithm anyway. In vector::insert(it, count, val): Changed the out of range check to use std::less In TestVector.hpp: Added tests for the above
nliber
changed the title
dalg24
approved these changes
Apr 28, 2022
crtrott
approved these changes
Apr 28, 2022
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a fix for issue #4975.
In vector::insert(iterator, InputIterator, InputIterator):
Changed the out of range check on it to use std::less, as one
cannot portably perform ordered pointer comparisons on pointers
that aren't pointing inside the same array (to a first approximation).
Removed the special case when inserting into an empty vector,
as it was incorrect (see issue #4975) and has no real performance
gain (unlike this special case in insert(it, count, val)).
Removed the special case when inserting zero elements, as there
is no need to hand optimize for this rare case, as it falls out
of the general algorithm anyway.
In vector::insert(it, count, val):
Changed the out of range check to use std::less
In TestVector.hpp:
Added tests for the above