Do not include compiler warning flags in the compile option of the cmake target #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
force-pushed
the
do_not_export_warning_flags
branch
from
9c8f4b5
to
edba2d4
Compare
cz4rs
reviewed
Apr 29, 2022
masterleinad
approved these changes
Apr 29, 2022
cz4rs
approved these changes
Apr 29, 2022
nmm0
approved these changes
May 2, 2022
There was a problem hiding this comment.
Approved, but I think in the future we should switch to CMakePresets.json for developer configurations. We could have compiler-specific presets that devs can inherit from. This will also ensure that we have a common set of development environments that people use.
| ELSE() | ||
| STRING(REPLACE ";" " " WARNING_FLAGS "${COMMON_WARNINGS}") | ||
| ENDIF() | ||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${WARNING_FLAGS}") |
There was a problem hiding this comment.
We need to make sure no one is using this flag downstream because it can break subdirectory projects. At the very least we should document it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring with
-DKokkos_ENABLE_COMPILER_WARNINGS=ON(which developers will typically do), the cmake target installed has the warning flags as compile options. These are then passed downstream transitively which is just wrong. It gets irritating at times, I had to reconfigure and reinstall Kokkos (or edit the target) too many times.In other words, this PR makes a develop build suitable to use downstream.