complex(math) : log10 support

[romintomasetti]

This PR adds log10 support for Kokkos::complex type.

This PR targets #3877.

It also comes with the accompanying test in core/unit_test/TestComplex.hpp.

[dalg24-jenkins]

Can one of the admins verify this patch?

[dalg24]

Test this please

[dalg24]

Would you please fix the format

diff --git a/core/src/Kokkos_Complex.hpp b/core/src/Kokkos_Complex.hpp
index 63d144171..9c0387e1d 100644
--- a/core/src/Kokkos_Complex.hpp
+++ b/core/src/Kokkos_Complex.hpp
@@ -786,7 +786,7 @@ KOKKOS_INLINE_FUNCTION Kokkos::complex<RealType> log(
 }
 
 //! base 10 log of a complex number.
-template<typename RealType>
+template <typename RealType>
 KOKKOS_INLINE_FUNCTION Kokkos::complex<RealType> log10(
     const complex<RealType>& x) {
   return log(x) / log(RealType(10));

[romintomasetti]

Would you please fix the format

diff --git a/core/src/Kokkos_Complex.hpp b/core/src/Kokkos_Complex.hpp
index 63d144171..9c0387e1d 100644
--- a/core/src/Kokkos_Complex.hpp
+++ b/core/src/Kokkos_Complex.hpp
@@ -786,7 +786,7 @@ KOKKOS_INLINE_FUNCTION Kokkos::complex<RealType> log(
 }
 
 //! base 10 log of a complex number.
-template<typename RealType>
+template <typename RealType>
 KOKKOS_INLINE_FUNCTION Kokkos::complex<RealType> log10(
     const complex<RealType>& x) {
   return log(x) / log(RealType(10));

Done, thanks ! I also used class instead of typename, as for the other operators throughout Kokkos_Complex.hpp.

[dalg24]

OK to test

[dalg24]

Retest this please

[dalg24]

Retest this please

[dalg24]

Retest this please

[dalg24]

Retest this please...