Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KOKKOS_ENABLE_POSIX_MEMALIGN #5011

Merged
merged 1 commit into from
May 11, 2022

Conversation

masterleinad
Copy link
Contributor

KOKKOS_ENABLE_POSIX_MEMALIGN is only mentioned in

commit 8802c19fdfd492b70288daa8849d0d48f96441eb
Author: crtrott <crtrott@sandia.gov>
Date:   Wed Dec 2 12:27:33 2015 -0700

    Core: Add option KOKKOS_ENABLE_PERFORMANCE_POSIX_MEMALIGN
    This option is off by default, if defined we will use posix
    memalign for HostSpace, but it fails to allocate often.
    This only effects the new view implementation.  

in the whole git history. Hence, it seems to be untested and unused. We should consider removing it (or actually using and testing it).

@masterleinad masterleinad added the Question For Kokkos internal and external contributors and users label May 11, 2022
@dalg24 dalg24 requested a review from crtrott May 11, 2022 15:02
@dalg24
Copy link
Member

dalg24 commented May 11, 2022

Failure (SYCL perf test) is clearly unrelated

@dalg24 dalg24 merged commit ccfaab3 into kokkos:develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question For Kokkos internal and external contributors and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants