Add SKL and ICL as architectures #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
requested changes
May 11, 2022
cmake/kokkos_arch.cmake
Outdated
| DECLARE_AND_CHECK_HOST_ARCH(ICX "Intel Ice Lake Server CPUs (AVX512)") | ||
| DECLARE_AND_CHECK_HOST_ARCH(SKL "Intel Sky Lake Xeon E-class Client CPUs") |
There was a problem hiding this comment.
remove the Xeon on the Skylake and you can add a Xeon on the ICX i.e. also I think its one word. I.e. like this:
Intel Icelake Client CPUs (AVX512)
Intel Icelake Xeon Server CPUs (AVX512)
Intel Skylake Client CPUs
Intel Skylake Xeon Server CPUs (AVX512)
There was a problem hiding this comment.
It's Ice Lake and Skylake.
crtrott
approved these changes
May 11, 2022
dalg24
reviewed
May 11, 2022
| DECLARE_AND_CHECK_HOST_ARCH(SKX "Intel Sky Lake Xeon E-class HPC CPUs (AVX512)") | ||
| DECLARE_AND_CHECK_HOST_ARCH(ICL "Intel Ice Lake Client CPUs (AVX512)") | ||
| DECLARE_AND_CHECK_HOST_ARCH(ICX "Intel Ice Lake Xeon Server CPUs (AVX512)") | ||
| DECLARE_AND_CHECK_HOST_ARCH(SKL "Intel Skylake Client CPUs") |
There was a problem hiding this comment.
Is this one not missing the (AVX512)?
There was a problem hiding this comment.
No, not all of them support AVX512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #4929 (comment).
I also removed linking with
rtmsince transactional memory is not used anymore anyway.