Add Sapphire Rapids as architecture #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtrott
approved these changes
May 11, 2022
dalg24
reviewed
May 11, 2022
| @@ -57,6 +57,7 @@ DECLARE_AND_CHECK_HOST_ARCH(ICX "Intel Ice Lake Server CPUs (AVX51 | |||
| DECLARE_AND_CHECK_HOST_ARCH(SKX "Intel Sky Lake Xeon E-class HPC CPUs (AVX512)") | |||
| DECLARE_AND_CHECK_HOST_ARCH(KNC "Intel Knights Corner Xeon Phi") | |||
| DECLARE_AND_CHECK_HOST_ARCH(KNL "Intel Knights Landing Xeon Phi") | |||
| DECLARE_AND_CHECK_HOST_ARCH(SPR "Intel Sapphire Rapids Xeon Server CPUs (AVX512)") | |||
There was a problem hiding this comment.
Please confirm we should be saying "server"
There was a problem hiding this comment.
Yeah its fine, its kind of doubled since Xeon in and of itself implies server but its also fine to say it.
|
Please rebase |
masterleinad
force-pushed
the
add_sapphirerapids
branch
from
4e54423
to
f192521
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was already added to
clangin https://reviews.llvm.org/D86503 (which also usesSPRas abbreviation).