Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling ZeroMemset in deep_copy #5040

Merged
merged 5 commits into from
May 31, 2022
Merged

Conversation

masterleinad
Copy link
Contributor

While working on #5035, I realized that we don't call ZeroMemset in deep_copy as intended because std::is_trivially_copy_assignable<>::value is false for const types.

@dalg24
Copy link
Member

dalg24 commented May 20, 2022

BTW weren't we supposed to have kokkostool-based unit test for this?

@masterleinad
Copy link
Contributor Author

BTW weren't we supposed to have kokkostool-based unit test for this?

We have one for View initialization but that doesn't cover deep_copy.

if (std::is_same<typename TEST_EXECSPACE,
Kokkos::Experimental::OpenMPTarget>::value)
return;
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start using SKIP instead? (Not asking to change)

@masterleinad
Copy link
Contributor Author

Retest this please,

@masterleinad
Copy link
Contributor Author

Retest this please.

@dalg24
Copy link
Member

dalg24 commented May 31, 2022

Retest this please

@dalg24
Copy link
Member

dalg24 commented May 31, 2022

Any idea why GH workflow nor appveyor ran?

@masterleinad
Copy link
Contributor Author

Any idea why GH workflow nor appveyor ran?

They ran for 1bc763d.
[ci skip] also works for GitHub Workflows, see https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs, and appveyor, see https://www.appveyor.com/docs/how-to/filtering-commits/#skip-commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants