-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calling ZeroMemset in deep_copy #5040
Conversation
BTW weren't we supposed to have kokkostool-based unit test for this? |
We have one for View initialization but that doesn't cover deep_copy. |
e1d1958
to
6edd060
Compare
if (std::is_same<typename TEST_EXECSPACE, | ||
Kokkos::Experimental::OpenMPTarget>::value) | ||
return; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start using SKIP instead? (Not asking to change)
Retest this please, |
Retest this please. |
Retest this please |
Any idea why GH workflow nor appveyor ran? |
They ran for 1bc763d. |
While working on #5035, I realized that we don't call
ZeroMemset
indeep_copy
as intended becausestd::is_trivially_copy_assignable<>::value
isfalse
forconst
types.