Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5025: Fix ScatterMin/ScatterMax to use proper atomics (3.6.01 cherry-pick) #5046

Merged
merged 1 commit into from
May 23, 2022

Conversation

PhilMiller
Copy link
Contributor

No description provided.

@PhilMiller PhilMiller marked this pull request as draft May 20, 2022 22:34
@PhilMiller PhilMiller changed the title #5025: Fix ScatterMin/ScatterMax to use proper atomics #5025: Fix ScatterMin/ScatterMax to use proper atomics (3.6.01 cherry-pick) May 20, 2022
@PhilMiller PhilMiller added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Patch Release labels May 20, 2022
@PhilMiller PhilMiller added this to In Review in Developer: Phil Miller May 20, 2022
@crtrott crtrott marked this pull request as ready for review May 20, 2022 23:54
dalg24
dalg24 previously requested changes May 21, 2022
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can wait for 3.7

@PhilMiller
Copy link
Contributor Author

PhilMiller commented May 21, 2022

Christian suggested I mark it for the patch release. On a practical note, it'll make testing of the patch release easier.

@crtrott crtrott dismissed dalg24’s stale review May 23, 2022 19:18

Dismissed ...

@crtrott crtrott merged commit f004f54 into kokkos:release-candidate-3.6.01 May 23, 2022
Developer: Phil Miller automation moved this from In Review to Done, pending release May 23, 2022
@PhilMiller PhilMiller deleted the pm/scattermin36 branch July 27, 2022 21:57
@PhilMiller PhilMiller moved this from Done, pending release to Done in Release 3.6 in Developer: Phil Miller Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Patch Release
Projects
Developer: Phil Miller
Done in Release 3.6
Development

Successfully merging this pull request may close these issues.

None yet

3 participants