Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kokkos::Vector::push_back for default execution space #5047

Merged
merged 3 commits into from
May 23, 2022

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented May 20, 2022

Fixes #5042. The main change is to allocate (and initialize) create modified_flags if it's not yet allocated in modify.
Without this, resize is copying the device data which has not been modified.

containers/unit_tests/TestVector.hpp Outdated Show resolved Hide resolved
containers/unit_tests/TestVector.hpp Outdated Show resolved Hide resolved
containers/unit_tests/TestVector.hpp Show resolved Hide resolved
@dalg24
Copy link
Member

dalg24 commented May 23, 2022

Retest this please

@masterleinad
Copy link
Contributor Author

masterleinad commented May 23, 2022

@overfelt Can you confirm that this fixes your problem?

@overfelt
Copy link

Yes, I'll rerun my tests. Takes a while to build.

@overfelt
Copy link

Yes, this fixes my problem.

@dalg24
Copy link
Member

dalg24 commented May 23, 2022

OpenMPTarget-ROCm-4.5 failure seems unrelated

lld: error: /tmp/libkokkoscore-gfx906-ade9a8-gfx906-290beb.o: symbol _HASHW_/var/jenkins/workspace/Kokkos@2/core/unit_test/tools/TestEventCorrectness_cpp__omp_outlined___22_wrapper has undefined version 2/core/unit_test/tools/TestEventCorrectness_cpp__omp_outlined___22_wrapper
lld: error: /tmp/libkokkoscore-gfx906-ade9a8-gfx906-290beb.o: symbol _HASHW_/var/jenkins/workspace/Kokkos@2/core/unit_test/tools/TestEventCorrectness_cpp__omp_outlined___24_wrapper has undefined version 2/core/unit_test/tools/TestEventCorrectness_cpp__omp_outlined___24_wrapper
clang-13: error: amdgcn-link command failed with exit code 1 (use -v to see invocation)
make[2]: *** [core/unit_test/CMakeFiles/KokkosCore_UnitTest_KokkosP.dir/build.make:136: core/unit_test/KokkosCore_UnitTest_KokkosP] Error 1
make[1]: *** [CMakeFiles/Makefile2:2294: core/unit_test/CMakeFiles/KokkosCore_UnitTest_KokkosP.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

@dalg24 dalg24 merged commit 09e89b6 into kokkos:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants