Remove KOKKOS_THREAD_LOCAL #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
approved these changes
May 26, 2022
dalg24
approved these changes
May 26, 2022
|
How sure are we that no one downstream uses that? Maybe deprecate for 3.7 and then remove (could define it to KOKKOS_THREAD_LOCAL = thread_local? |
crtrott
previously requested changes
May 26, 2022
|
OK with what Christian suggest. |
It's not used in |
dalg24
reviewed
May 26, 2022
masterleinad
force-pushed
the
remove_kokkos_thread_local
branch
from
4d1ac27
to
4973f49
Compare
|
Not sure what is going on with Jenkins but that commit was built successfully so I am going to merge as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't really seem any need to define this macro when we can use
thread_localinstead.