-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn instead of just ignoring user settings when kokkos-tools is disabled #5088
Warn instead of just ignoring user settings when kokkos-tools is disabled #5088
Conversation
This is only a draft because |
9d24b2c
to
53304d3
Compare
On second thought, I suggest we merge this and consider this as a known defect in 3.7 that we will fix in 4.0 |
Clang+CUDA build failure is clearly unrelated. This is ready for review. |
53304d3
to
d1a50a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Ignoring OPENMPTARGET-Clang failure (timeout in KokkosCore_UnitTest_Serial1) |
Fix #5085
Raise a warning when the user passes a command line argument or sets an environment variable that is ignored because kokkos-tools is not actually enabled.
Drive-by change: refactor duplicated code to remove kokkos-tools flags