CMake: Only show GPU architectures with enabled corresponding backend #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jun 16, 2022
|
How does this work with SYCL on NVIDIA? |
dalg24
reviewed
Jun 16, 2022
You have to use |
|
ok sounds good |
nmm0
requested changes
Jun 16, 2022
cmake/kokkos_functions.cmake
Outdated
| LIST(APPEND KOKKOS_OPTION_TYPES BOOL) | ||
| SET(KOKKOS_OPTION_TYPES ${KOKKOS_OPTION_TYPES} PARENT_SCOPE) | ||
|
|
||
| CMAKE_DEPENDENT_OPTION(${CAMEL_NAME} ${DOCSTRING} ${DEFAULT} "${DEPENDENCY}" OFF) |
There was a problem hiding this comment.
we should have a FORCE argument so the api is the same as cmake_dependent_option
| @@ -57,7 +57,46 @@ FUNCTION(kokkos_option CAMEL_SUFFIX DEFAULT TYPE DOCSTRING) | |||
| # Make sure this appears in the cache with the appropriate DOCSTRING | |||
| SET(${CAMEL_NAME} ${DEFAULT} CACHE ${TYPE} ${DOCSTRING}) | |||
|
|
|||
| #I don't love doing it this way because it's N^2 in number options, but cest la vie | |||
| #I don't love doing it this way because it's N^2 in number options, but c'est la vie | |||
There was a problem hiding this comment.
thanks for adding a fix to the missing ' it was really bugging me :P
nmm0
approved these changes
Jun 16, 2022
dalg24
reviewed
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion in the meeting yesterday, we use cmake_dependent_option for the architecture options to only show GPU architectures in
ccmakeif the corresponding backend is enabled (or we configure withKokkos_ENABLE_UNSUPPORTED_ARCHS=ON). This should make theCMakeoption a little less overwhelming.